Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle error messages from remote protocol correctly. #853

Merged
merged 1 commit into from
Oct 31, 2016
Merged

Handle error messages from remote protocol correctly. #853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lighthouse-cli/bin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,9 @@ function showConnectionError() {

function showRuntimeError(err: LightHouseError) {
console.error('Runtime error encountered:', err);
console.error(err.stack);
if (err.stack) {
console.error(err.stack);
}
process.exit(_RUNTIME_ERROR_CODE);
}

Expand Down
4 changes: 2 additions & 2 deletions lighthouse-core/gather/connections/connection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ class Connection {
this._callbacks.delete(object.id);
if (object.error) {
log.formatProtocol('method <= browser ERR',
{method: callback.method, params: object.result}, 'error');
callback.reject(object.result);
{method: callback.method}, 'error');
callback.reject(object.error);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might want to augment this message with information about it being from the debugging protocol (since I believe the log above that will only be on if you specify --verbose)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should just new up an Error object? I can't vouch for the entire code base (yet) but it would be nice if any errors that flow through the promise pipeline were of a similar 'shape'

Copy link
Contributor Author

@shakyShane shakyShane Oct 31, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... plus augment as you suggest

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of both. Make the source of the error clear in the message (at the very least it'll make bug reports easier to track down) and standardize on reject(new Error(msg)) so that we can depend on the shape.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also by creating a new Error inline there, anyone can print the stack and at the very least get back to this protocol handling bit

return;
}
log.formatProtocol('method <= browser OK',
Expand Down