Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report(lightwallet): render performance-budget section #8708

Merged
merged 5 commits into from
May 7, 2019
Merged

report(lightwallet): render performance-budget section #8708

merged 5 commits into from
May 7, 2019

Conversation

khempenius
Copy link
Collaborator

@khempenius khempenius commented Apr 29, 2019

Summary

Related Issues/PRs
#8675, #8427, #8709, #8708,#8522, #8539

Screen Shot 2019-04-29 at 8 55 04 AM

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: current rendering is roughly this: https://lighthouse-dti65h1bz.now.sh/


This is just the basic table to start?

Seems like you'll have a followup that adds the "over budget" column and all that, yeah?

@khempenius
Copy link
Collaborator Author

Updated.

@paulirish paulirish added the P0 label May 5, 2019
@brendankenny brendankenny changed the title lightwallet: render 'budgets' section report(lightwallet): render performance-budget section May 5, 2019
@brendankenny
Copy link
Member

@paulirish is it possible to redeploy this with new master?

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khempenius this is looking good to me. Do you mind rebasing/merging from master so that this pulls in the change (#8870) to get performance-budget results in the sample json? Should clean up some of the tests and make the auto deployed example include the table

@paulirish
Copy link
Member

woohoo! now we got budget section in the now deployment! https://lighthouse-gce0hkow5.now.sh/

image

Copy link
Member

@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only nit I have is that when a budget fails the info kinda shows up twice in the Budgets group and in the Diagnostics group:
image

But that's not really a showstopped.

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! Mostly style nits now

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wohoo we are almost there!! 😮 🎉

@khempenius
Copy link
Collaborator Author

Updated.

All resolved except this comment from @patrickhulce:
"also not sure if we should do this by audit id or by group and/or if there's any point to having the budgets group anymore if we keep it by id?

FWIW I think I'd lean towards group since that's how we're doing everything else, but then again it might be a bit confusing that it's a single audit in the group so 🤷‍♂"

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brendankenny brendankenny merged commit bbb3978 into GoogleChrome:master May 7, 2019
@brendankenny
Copy link
Member

🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants