Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(link): Update broken plugin example link #9524

Merged
merged 1 commit into from Aug 7, 2019
Merged

fix(link): Update broken plugin example link #9524

merged 1 commit into from Aug 7, 2019

Conversation

alabiaga
Copy link
Contributor

@alabiaga alabiaga commented Aug 7, 2019

Fix broken plugin example link

@alabiaga alabiaga changed the title fix broken plugin example link fix(link): Update broken plugin example link Aug 7, 2019
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks very much @alabiaga!

@alabiaga
Copy link
Contributor Author

alabiaga commented Aug 7, 2019

@patrickhulce No problem. Also the plugin example doesn't quite work for me. I get the chrome example.com instance up when running the command mentioned (npx lighthouse https://example.com --plugins=lighthouse-plugin-example --view) in the readme but don't see the the plugin results as the screenshot indicates? Should I file a bug or am I missing something? Thanks

@patrickhulce
Copy link
Collaborator

but don't see the the plugin results as the screenshot indicates? Should I file a bug or am I missing something?

Are you sure you've installed the recipe package at the same level as lighthouse? We might want to update the instructions to elaborate on that point since at the moment it's somewhat unclear what it takes to run it.

@alabiaga
Copy link
Contributor Author

alabiaga commented Aug 7, 2019

but don't see the the plugin results as the screenshot indicates? Should I file a bug or am I missing something?

Are you sure you've installed the recipe package at the same level as lighthouse? We might want to update the instructions to elaborate on that point since at the moment it's somewhat unclear what it takes to run it.

Install as a (peer) dependency, parallel to lighthouse
Yea this wasn't clear to me. Got it. Thanks

@alabiaga
Copy link
Contributor Author

alabiaga commented Aug 7, 2019

@alabiaga merge pls.

@patrickhulce patrickhulce merged commit 2d166e0 into GoogleChrome:master Aug 7, 2019
@alabiaga alabiaga deleted the plugin-link-fix branch August 7, 2019 20:09
paulirish pushed a commit that referenced this pull request Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants