Improve github issue title #992
Conversation
| @@ -53,7 +53,7 @@ document.addEventListener('DOMContentLoaded', _ => { | |||
| qsBody += '**Stack Trace**:\n ```' + err.stack + '```'; | |||
|
|
|||
| const base = 'https://github.com/googlechrome/lighthouse/issues/new?'; | |||
| const title = encodeURI('title=Lighthouse Extension Error'); | |||
| const title = encodeURI('title=Extension Error: ' + err.message); | |||
| const body = '&body=' + encodeURI(qsBody); | |||
There was a problem hiding this comment.
I feel like this would benefit from some upper bound truncation in case the err.message gets a little long.
There was a problem hiding this comment.
Mocking this up in Chrome, Github seems to new line around 77 characters (at my res) per line (60 characters of this error message).
Are two lines okay, or is one line preferable?
There was a problem hiding this comment.
+1 on truncation. We don't gain much after the first line and the entire message is already in the body.
There was a problem hiding this comment.
@addyosmani @ebidel Done, and now this PR truncates appened error messages at 60 characters.
| const title = encodeURI('title=Extension Error: ' + err.message); | ||
| let titleError = err.message; | ||
| if (titleError.length > MAX_ISSUE_ERROR_LENGTH) { | ||
| titleError = err.message.substring(0, MAX_ISSUE_ERROR_LENGTH - 3) + '...'; |
There was a problem hiding this comment.
use titleError:
titleError = `${titleError.substring(0, MAX_ISSUE_ERROR_LENGTH - 3)}...`;
There was a problem hiding this comment.
@ebidel 👍 concatenation replaced with template literal
| @@ -53,7 +55,11 @@ document.addEventListener('DOMContentLoaded', _ => { | |||
| qsBody += '**Stack Trace**:\n ```' + err.stack + '```'; | |||
|
|
|||
| const base = 'https://github.com/googlechrome/lighthouse/issues/new?'; | |||
| const title = encodeURI('title=Lighthouse Extension Error'); | |||
| let titleError = err.message; | |||
| if (titleError.length > MAX_ISSUE_ERROR_LENGTH) {; | |||
There was a problem hiding this comment.
@brendankenny done!
|
🍻 |
Currently the Lighthouse Extension Errors create a generic title that is too ambiguous to differentiate duplicates without actually clicking on the issue.
This PR appends the JS error to the title.