Skip to content

Commit

Permalink
feat(chromium): roll Chromium to r648643 (#4256)
Browse files Browse the repository at this point in the history
This roll includes:
- https://crrev.com/648335 -
[DevTools] Send DevTools request ID through URLLoader
- https://crrev.com/648360 -
[DevTools] Add renderer request ID to requestIntercepted

References #3471
  • Loading branch information
aslushnikov committed Apr 8, 2019
1 parent 080b809 commit 9d31068
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
2 changes: 2 additions & 0 deletions lib/Launcher.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ const DEFAULT_ARGS = [
'--disable-features=site-per-process,TranslateUI,BlinkGenPropertyTrees',
'--disable-hang-monitor',
'--disable-ipc-flooding-protection',
// TODO: Perfetto is disabled due to crbug.com/950620
'--disable-perfetto',
'--disable-popup-blocking',
'--disable-prompt-on-repost',
'--disable-renderer-backgrounding',
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"node": ">=6.4.0"
},
"puppeteer": {
"chromium_revision": "647475"
"chromium_revision": "648643"
},
"scripts": {
"unit": "node test/test.js",
Expand Down
2 changes: 2 additions & 0 deletions test/page.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,8 @@ module.exports.addTests = function({testRunner, expect, headless, Errors, Device
expect(message.type()).toEqual('warn');
});
it_fails_ffox('should have location when fetch fails', async({page, server}) => {
// The point of this test is to make sure that we report console messages from
// Log domain: https://vanilla.aslushnikov.com/?Log.entryAdded
await page.goto(server.EMPTY_PAGE);
const [message] = await Promise.all([
waitEvent(page, 'console'),
Expand Down

0 comments on commit 9d31068

Please sign in to comment.