Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad font rendering on Linux #2927

Closed
slyrz opened this issue Jul 20, 2018 · 10 comments
Closed

Bad font rendering on Linux #2927

slyrz opened this issue Jul 20, 2018 · 10 comments
Assignees
Labels

Comments

@slyrz
Copy link

slyrz commented Jul 20, 2018

Tell us about your environment:

  • Puppeteer version: 1.6.0
  • Platform / OS version: Ubuntu 16.04 LTS

Just to let you know, 1.6.0 is pinned to a Chromium version with broken font rendering on Linux,
so screenshots for Linux users might look bad.

I think this was caused by a fontconfig update and was eventually fixed in this commit. This should give you the timespan of "broken" Chromium builds.

For comparison:

  • Revision 574897 (currently pinned)
    news ycombinator com_ 1

  • Revision 576827 (latest build)
    news ycombinator com_ 2

@aslushnikov aslushnikov self-assigned this Jul 20, 2018
@MrTurnRight
Copy link

can i use 'npm update' to fix this bug?
i dont know how to fix it

@slyrz
Copy link
Author

slyrz commented Jul 23, 2018

So far the published version hasn't changed. You can work around this by using the BrowserFetcher to run a different Chromium revision:

const browserFetcher = puppeteer.createBrowserFetcher();
const revisionInfo = await browserFetcher.download('576827');
const browser = await puppeteer.launch({ executablePath: revisionInfo.executablePath })

@aslushnikov
Copy link
Contributor

Thanks @slyrz for the workaround. We'll push an updated 1.6.1 shortly.

@aslushnikov
Copy link
Contributor

For the record: upstream bug for this is https://crbug.com/857511

@aslushnikov
Copy link
Contributor

Puppeteer v1.6.1 is live with an updated chromium revision to address this bug.

https://github.com/GoogleChrome/puppeteer/releases/tag/v1.6.1

@aslushnikov
Copy link
Contributor

@MrTurnRight I don't think this is related; there are quite a few reports with various solutions regarding Chinese fonts: https://github.com/GoogleChrome/puppeteer/issues?q=is%3Aissue+Chinese+is%3Aclosed

@MrTurnRight
Copy link

thank you , i found the solution. im so sorry.

@Tusko
Copy link

Tusko commented Mar 18, 2019

@MrMitch how did you fix it?

@MrMitch
Copy link
Contributor

MrMitch commented Mar 18, 2019

@Tusko I think you meant to mention @MrTurnRight and not me ;)

@WeihanLi
Copy link

thank you , i found the solution. im so sorry.

@MrTurnRight , could you please share your solution? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants