Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump version to 1.0.0rc #1389

Merged
merged 1 commit into from
Nov 14, 2017
Merged

Conversation

aslushnikov
Copy link
Contributor

No description provided.

@aslushnikov aslushnikov merged commit 99103cb into puppeteer:master Nov 14, 2017
@joelgriffith
Copy link
Contributor

Dumb question: does this also entail puppeteer landing/packing a stable version of Chrome as well?

@aslushnikov
Copy link
Contributor Author

@joelgriffith no, this step is to stabilize PPTR api.

@alixaxel
Copy link
Contributor

@aslushnikov Are there any plans to export the Page class from PPTR in version 1.0.0? Right now, if I want to add methods to the Page prototype, I need to run the same lib/es6 switch logic that is present in index.js. Would be great if Page and other first-class classes were exported as non-defaults.

@aslushnikov
Copy link
Contributor Author

@alixaxel we currently have no plans to expose inner classes.

For your usecase, would it work if you just add methods to both node6 and regular versions of page?

function extendPuppeteer() {
  extendPage(require('lib/Page'));
  extendPage(require('node6/Page'));
}

function extendPage(pageClass) {
  pageClass.prototype.foo = function() {
    // ...
  }
}

@alixaxel
Copy link
Contributor

@aslushnikov Yeah, exporting would be more elegant but something like that will do yes.

@aslushnikov
Copy link
Contributor Author

@aslushnikov Yeah, exporting would be more elegant

@alixaxel Would be. The reason we're reluctant on exporting classes is to limit API abuse: without classes there's no daunting desire to run constructors with hacked-in arguments.

@aslushnikov aslushnikov deleted the bump branch January 25, 2018 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants