feat(Network): implement request.redirectChain() api #2194
Conversation
|
|
lib/NetworkManager.js
Outdated
| * @return {!Array<!Request>} | ||
| */ | ||
| redirectChain() { | ||
| return this._redirectChain; |
There was a problem hiding this comment.
It looks like we are returning a live array that might change after the user receives it. Slice here?
|
@JoelEinbinder i don't think so. I think I fix flakiness in #2195 (btw, ptal) |
aslushnikov
force-pushed
the
redirect-chain
branch
from
f9b01e7
to
9107a39
Compare
|
@JoelEinbinder addressed comments; ptal. |
The request.redirectChain() returns all the requests issued to fetch the resource. Fixes puppeteer#1816.
aslushnikov
force-pushed
the
redirect-chain
branch
from
ced8ea6
to
80176e1
Compare
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
The request.redirectChain() returns all the requests issued to fetch
the resource.
Fixes #1816.