Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test on Page.evaluateOnNewDocument with CSP #2319

Merged
merged 3 commits into from
Apr 6, 2018

Conversation

aslushnikov
Copy link
Contributor

This patch adds a test that Page.evaluateOnNewDocument works
with CSP: there's been some concerns on the bugtracker before.

References #1229

This patch adds a test that Page.evaluateOnNewDocument works
with CSP: there's been some concerns on the bugtracker before.

References puppeteer#1229
Copy link
Contributor

@JoelEinbinder JoelEinbinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do this with the header. Maybe the eval happens before the meta tag somehow?

Copy link
Contributor

@JoelEinbinder JoelEinbinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Csp.html is unused

@aslushnikov
Copy link
Contributor Author

Csp.html is unused

Comes handy; I'll use it in a follow-up

@aslushnikov aslushnikov merged commit 4663b43 into puppeteer:master Apr 6, 2018
@aslushnikov aslushnikov deleted the eval-csp branch May 9, 2018 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants