fix(launcher): always add about:blank to default arguments
#2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome Headless used to open about:blank by default; however, this was recently changed. We should open starting page no matter what to keep the environment predictable.
aslushnikov
changed the title
about:blank to default arguments.about:blank to default arguments
| @@ -97,7 +97,7 @@ class Launcher { | |||
| if (os.platform() === 'win32') | |||
| chromeArguments.push('--disable-gpu'); | |||
| } | |||
| if (!options.ignoreDefaultArgs && Array.isArray(options.args) && options.args.every(arg => arg.startsWith('-'))) | |||
There was a problem hiding this comment.
This is a slight functionality change. There is now no way to get the newtab page in headful chrome as the startup tab. That is probably fine though.
There was a problem hiding this comment.
There is now no way to get the newtab page in headful chrome as the startup tab.
I think you can navigate to chrome://newtab
JoelEinbinder
approved these changes
Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome Headless used to open about:blank by default; however, this
was recently changed.
We should open starting page no matter what to keep the environment
predictable.