Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger "RWS submission checks" action daily at 9am EST #279

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

aselya
Copy link
Collaborator

@aselya aselya commented Feb 20, 2024

This commit will cause the "RWS submission checks" to run daily at 9am EST. It utilizes the "schedule" event trigger and cron as described in https://docsgithub.com/en/actions/using-workflows/events-that-trigger-workflows#schedule

@aselya
Copy link
Collaborator Author

aselya commented Feb 20, 2024

Limitations:
The trigger time is set as 9am EST but there appears to be no assurance that the job will run at 9am. If this isn't running by the time pull requests get reviewed the time should be changed to something earlier.

It also will not apply to any pull requests that were created before the change gets merged in so reviewers should still confirm that the checks have run.

@cfredric cfredric self-assigned this Feb 20, 2024
aselya and others added 2 commits February 21, 2024 13:06
Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com>
Copy link

Looks like you've passed all of the checks!

Copy link
Collaborator

@cfredric cfredric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, go ahead and merge when ready

@aselya aselya merged commit 90e2751 into main Feb 23, 2024
4 checks passed
cfredric added a commit to cfredric/chrome-first-party-sets that referenced this pull request Mar 11, 2024
…#279)

* Trigger job daily at 9am EST using cron as described in https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule

* Update .github/workflows/rws-submissions-checks.yml

Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com>

---------

Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants