Skip to content
This repository has been archived by the owner on Oct 6, 2022. It is now read-only.

Explicit render flag #289

Closed
Supamiu opened this issue May 7, 2019 · 1 comment
Closed

Explicit render flag #289

Supamiu opened this issue May 7, 2019 · 1 comment

Comments

@Supamiu
Copy link

Supamiu commented May 7, 2019

As I'm working with some firebase stuff and some requests that can pretty much hang for dozens of seconds even if they are useless for the rendering process, I wanted to use a render flag to tell the renderer I finished rendering my page.

So I found this PR: #126 that adds exactly what I want.

I implemented it inside my page and realized that it wasn't working.

By looking at the source code, it seems like this has been entirely removed and there's no way to tell the renderer when you finished the rendering explicitly.

Is this planned for a future release? Or should I just try to implement it and PR?

Edit:

By taking a look at pupeteer, it seems like the best I can do for now is to change "networkidle0" for "networkidle2", but it's sadly not enough to fix my issue :/

@AVGP
Copy link
Collaborator

AVGP commented Sep 9, 2019

This seems to have been removed with the switch to Puppeteer indeed.
Unfortunately, it seems that Puppeteer isn't going to add the possibility to listen to events..

Closing this issue for now, feel free to reopen, if you wanna take a stab at this with a PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants