Skip to content
This repository has been archived by the owner on Oct 6, 2022. It is now read-only.

Upgrade puppeteer to latest (10.0.0) #683

Merged
merged 2 commits into from
Jul 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
128 changes: 76 additions & 52 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"koa-send": "^5.0.1",
"koa-static": "^5.0.0",
"performance-now": "^2.1.0",
"puppeteer": "^5.5.0",
"puppeteer": "^10.0.0",
"semver": "^7.3.4"
},
"devDependencies": {
Expand Down
10 changes: 5 additions & 5 deletions src/renderer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,20 +127,20 @@ export class Renderer {

await page.setRequestInterception(true);

page.addListener('request', (interceptedRequest: puppeteer.Request) => {
page.on('request', (interceptedRequest: puppeteer.HTTPRequest) => {
if (this.restrictRequest(interceptedRequest.url())) {
interceptedRequest.abort();
} else {
interceptedRequest.continue();
}
});

let response: puppeteer.Response | null = null;
let response: puppeteer.HTTPResponse | null = null;
// Capture main frame response. This is used in the case that rendering
// times out, which results in puppeteer throwing an error. This allows us
// to return a partial response for what was able to be rendered in that
// time frame.
page.addListener('response', (r: puppeteer.Response) => {
page.on('response', (r: puppeteer.HTTPResponse) => {
if (!response) {
response = r;
}
Expand Down Expand Up @@ -265,7 +265,7 @@ export class Renderer {

await page.setRequestInterception(true);

page.addListener('request', (interceptedRequest: puppeteer.Request) => {
page.addListener('request', (interceptedRequest: puppeteer.HTTPRequest) => {
if (this.restrictRequest(interceptedRequest.url())) {
interceptedRequest.abort();
} else {
Expand All @@ -277,7 +277,7 @@ export class Renderer {
await page.emulateTimezone(timezoneId);
}

let response: puppeteer.Response | null = null;
let response: puppeteer.HTTPResponse | null = null;

try {
// Navigate to page. Wait until there are no oustanding network requests.
Expand Down
3 changes: 2 additions & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"sourceMap": true,
"lib": ["es2017", "esnext.asynciterable", "dom"],
"rootDir": "./src",
"outDir": "./build"
"outDir": "./build",
"skipLibCheck": true
},
"include": ["./src/**/*.ts"]
}