[webtransport] remove unnecessary code #764
Conversation
jlaine
force-pushed
the
webtransport-update
branch
2 times, most recently
from
a5b58e8
to
5dba55a
Compare
aioquic 0.9.19 already contains all the necessary settings for WebTransport, so there is no reason to subclass H3Connection.
jlaine
force-pushed
the
webtransport-update
branch
from
5dba55a
to
afa4f91
Compare
|
@yutakahirano @bashi I suspect the WPT code can also be simplified in this manner |
|
If @yutakahirano or @bashi can give their 👍 from a technical point of view, I'm happy to get this merged. |
|
LGTM, nice cleanup! I haven't tested locally though. I'll try to update wpt server when I have time (I'm a bit swamped these days) |
|
Thank you for the change! |
|
I realized that we can't update aioquic to 0.9.19 in WPT tools for now since the latest aioquic requires Python 3.7+ but WPT tools need to support Python 3.6. |
That's unfortunate, Python 3.6 reached end of life at the end of 2021, it's no longer maintained. That's the reason I dropped support for Python 3.6 in aioquic and all my projects. |
|
Question: The sample WebTransport client (https://github.com/googlechrome/samples/tree/gh-pages/webtransport) no longer seems to work with the latest WebTransport server. Has something changed? |
|
Looks like it's working on my local environment. Could you force-reload then try again? Are there any errors in the DevTools console? |
aioquic 0.9.19 already contains all the necessary settings for
WebTransport, so there is no reason to subclass H3Connection.