Add getter to polyfill

GoogleChrome · Jan 12, 2021 · ddff4a1 · ddff4a1
1 parent d0c3535
commit ddff4a1
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/src/lib/polyfills/firstHiddenTimePolyfill.ts → ...b/polyfills/getFirstHiddenTimePolyfill.ts b/src/lib/polyfills/firstHiddenTimePolyfill.ts → ...b/polyfills/getFirstHiddenTimePolyfill.ts
@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-export let firstHiddenTime =
+let firstHiddenTime =
     document.visibilityState === 'hidden' ? 0 : Infinity;
 
 const onVisibilityChange = (event: Event) => {
@@ -26,3 +26,5 @@ const onVisibilityChange = (event: Event) => {
 
 // Note: do not add event listeners unconditionally (outside of polyfills).
 addEventListener('visibilitychange', onVisibilityChange, true);
+
+export const getFirstHiddenTime = () => firstHiddenTime;
diff --git a/src/polyfill.ts b/src/polyfill.ts
@@ -15,10 +15,15 @@
  */
 
 import {firstInputPolyfill, resetFirstInputPolyfill} from './lib/polyfills/firstInputPolyfill.js';
-import {firstHiddenTime} from './lib/polyfills/firstHiddenTimePolyfill.js';
+import {getFirstHiddenTime} from './lib/polyfills/getFirstHiddenTimePolyfill.js';
 
 resetFirstInputPolyfill();
-self['webVitals'] = self['webVitals'] || {};
-self['webVitals']['firstInputPolyfill'] = firstInputPolyfill;
-self['webVitals']['resetFirstInputPolyfill'] = resetFirstInputPolyfill;
-self['webVitals']['firstHiddenTime'] = firstHiddenTime;
+self.webVitals = {
+  firstInputPolyfill: firstInputPolyfill,
+  resetFirstInputPolyfill: resetFirstInputPolyfill,
+  // TODO: in v2 this should just be `getFirstHiddenTime()`,
+  // but in v1 it needs to be a getter to avoid creating a breaking change.
+  get firstHiddenTime() {
+    return getFirstHiddenTime();
+  },
+};