Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a note about when to load the library #305

Merged
merged 2 commits into from Jan 12, 2023
Merged

Add a note about when to load the library #305

merged 2 commits into from Jan 12, 2023

Conversation

tunetheweb
Copy link
Member

Fixes #304

@tunetheweb tunetheweb mentioned this pull request Jan 11, 2023
Closed
philipwalton
philipwalton approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@philipwalton philipwalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (suggested a slight reword)

README.md Outdated Show resolved Hide resolved
@tunetheweb @philipwalton
Update README.md
e289a32 
Co-authored-by: Philip Walton <philipwalton@users.noreply.github.com>
@tunetheweb tunetheweb merged commit 0a87ab0 into main Jan 12, 2023
@tunetheweb tunetheweb deleted the when-to-load branch January 13, 2023 13:06
@lisr lisr mentioned this pull request May 24, 2023
Closed
@sethulakshmi-pm sethulakshmi-pm mentioned this pull request Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipwalton philipwalton philipwalton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs should mention "when to load"
2 participants
@tunetheweb @philipwalton