Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent LCP being reported for hidden prerendered page #326

Conversation

tunetheweb
Copy link
Member

Fixes #325

Note not adding a test case for this as a bit niche and racey and so would likely be flakey.

@tunetheweb tunetheweb merged commit 87358fc into main Mar 6, 2023
@tunetheweb tunetheweb deleted the 325-hidden-lcp-can-be-incorrectly-reported-for-prerendered-pages branch March 9, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onLCP may report even page was hidden previously
1 participant