Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pending LoAF cleanup logic #493

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Fix pending LoAF cleanup logic #493

merged 1 commit into from
Jun 10, 2024

Conversation

brendankenny
Copy link
Member

@brendankenny brendankenny commented Jun 10, 2024 •
edited
Loading

introduced in d41f3bc in #487

philipwalton
philipwalton approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@philipwalton philipwalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(🤦 ... I could have sworn I tested this!)

@brendankenny
Copy link
Member Author

Well it works for the first LoAF, and I think that's all we've ever observed it happen to :)

@brendankenny brendankenny merged commit ecec823 into main Jun 10, 2024
7 of 8 checks passed
@brendankenny brendankenny deleted the off-by-i branch June 10, 2024 23:48
@philipwalton philipwalton changed the title fix cleanup loop over pending LoAFs Fix pending LoAF cleanup logic Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipwalton philipwalton philipwalton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brendankenny @philipwalton