Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: added requestStart to the TTFB formula #9

Closed

Conversation

Zizzamia
Copy link
Contributor

Super excited to see Time to First Byte joining the WebVitals family 🌲🚀🌕

I was wondering why TTFB is based only as navigationEntry.responseStart instead of being the combination of navigationEntry.responseStart - navigationEntry.requestStart. Doing this subtraction will imply not including browser set up, redirects, or tcp and ssl negotiation in the final result.

I originally learn about this way of calculating TTFB by the Assessing Loading Performance in Real Life with Navigation and Resource Timing article.

I made a tiny PR with this change in case you and the team believe navigationEntry.responseStart - navigationEntry.requestStart could work better to guide developer with this tool.

Thank you @philipwalton 🙌

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@philipwalton
Copy link
Member

Thanks for the suggestion, but this library aims to track these metrics in a way that matches (as closely as possible) how they're tracked by Chrome and exposed in tools like the Chrome User Experience Report.

In the Chrome User Experience Report, TTFB measures the time between the navigation entry's responseStart property and the page's time origin (i.e. startTime).

To reduce confusion, though, I've submitted #12 which adds an example to the documentation clarifying this and also showing how you could use the getTTFB() function to measure what you've proposed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants