Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Clarify <a> vs <button> language in #1020

Closed
robdodson opened this issue Jun 19, 2019 · 0 comments · Fixed by #1150
Closed

Clarify <a> vs <button> language in #1020

robdodson opened this issue Jun 19, 2019 · 0 comments · Fixed by #1150
Labels
eng - bug Something broke! P3 A "nice to have" or stretch goal.

Comments

@robdodson
Copy link
Contributor

Describe the bug
See #1017

https://web.dev/use-semantic-html
The text in this article is a little unclear when to use an anchor or a button. We mention adding new content to the page is allowed if you're using an anchor, but we should be more specific and say if you're using an anchor to navigate within a SPA and you use routing to update the URL then you should use an anchor.

@robdodson robdodson added eng - bug Something broke! P3 A "nice to have" or stretch goal. labels Jun 19, 2019
@robdodson robdodson added this to To do in 🏃‍♀️DevSite migration via automation Jul 1, 2019
@robdodson robdodson added this to the Sprint 7.17.19 milestone Jul 1, 2019
@robdodson robdodson moved this from To do to In progress in 🏃‍♀️DevSite migration Jul 12, 2019
@robdodson robdodson moved this from In progress to Review in progress in 🏃‍♀️DevSite migration Jul 16, 2019
🏃‍♀️DevSite migration automation moved this from Review in progress to Done Jul 16, 2019
@webby-probot webby-probot bot added the done label Jul 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng - bug Something broke! P3 A "nice to have" or stretch goal.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant