This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
Only deploy if HEAD is different from what's currently deployed #3655
Labels
accepted
**Should be used by Eng team only**: Use this to tell the stalebot to keep a bug or PR open.
feature request
New feature or request
Projects
Comments
cc @GoogleChrome/web-dev-eng |
robdodson
added
the
accepted
**Should be used by Eng team only**: Use this to tell the stalebot to keep a bug or PR open.
label
Aug 10, 2020
Another possibility: use the HEAD value as the version deployed to App Engine. We can check if that version is already deployed and skip if so. |
Hm... i wonder how this would work in a Firebase world... I wonder if we should create a version.txt file or something as part of the deploy and dump the info there and sneak it into the firebase deploy. Then we'd fetch that file to check? |
MichaelSolati
added a commit
that referenced
this issue
Apr 21, 2021
MichaelSolati
added a commit
that referenced
this issue
Apr 21, 2021
MichaelSolati
added a commit
that referenced
this issue
Apr 21, 2021
MichaelSolati
added a commit
that referenced
this issue
Apr 21, 2021
MichaelSolati
added a commit
that referenced
this issue
Apr 23, 2021
MichaelSolati
added a commit
that referenced
this issue
Apr 23, 2021
MichaelSolati
added a commit
that referenced
this issue
Apr 23, 2021
MichaelSolati
added a commit
that referenced
this issue
Apr 23, 2021
MichaelSolati
added a commit
that referenced
this issue
Apr 23, 2021
MichaelSolati
added a commit
that referenced
this issue
Apr 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
accepted
**Should be used by Eng team only**: Use this to tell the stalebot to keep a bug or PR open.
feature request
New feature or request
Is your feature request related to a problem? Please describe.
We recently switched to deploying the site hourly. This is great, but it also means we're often deploying the same version of the site.
Describe the solution you'd like
We should only deploy if HEAD is different from the current live site.
Pete mentioned that on webfu they used a git-head.txt file to compare versions. I think the only downside to that approach is needing to check the git-head.txt file into source control with every PR.
Other options:
https://web.dev/version.json
. Then compare HEAD to that file.The text was updated successfully, but these errors were encountered: