Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Measure - http page is marked as https #393

Closed
hwikyounglee opened this issue Nov 9, 2018 · 4 comments
Closed

Measure - http page is marked as https #393

hwikyounglee opened this issue Nov 9, 2018 · 4 comments
Assignees

Comments

@hwikyounglee
Copy link

Raised by julialiang

Issues:

  1. The input field has 'https' as hint. It's misleading, e.g. does it check https only?, and not showing seems the right path forward.
  2. Also when I enter just URL without the scheme (http or https), the URL that's being monitored adds 'https' in the UI. It's also misleading since a site can be http only e.g. hani.co.kr
  3. Even when entering http url explicitly, e.g. http://hani.co.kr, it replaces http with https, and seems to throw an error if the site is http only. e.g. http://hani.co.kr - shows 500 api error, and http://bbc.com returns the scores (takes a long time though).
  4. When a site has both http and https site, e.g. bbc.com, it's unclear if the site is being tracked is actually http site or https site. See the screenshot - bbc.com audit item says it's not on HTTPS.

2018-11-09_10-37-29

@robdodson
Copy link
Contributor

Thanks Hwi! Good catch.

@TimvdLippe
Copy link
Contributor

This is working as intended per #175 For that issue, both urls missing a protocol or those starting with http:// are automatically converted to https://. Do we want to revert this functionality?

@robdodson
Copy link
Contributor

Yep, as we discussed tonight, I think we should revert it.

@TimvdLippe
Copy link
Contributor

Internalized as cl/221267486

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants