Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Add Banner component and add banner to all blog pages. #1178

Merged
merged 3 commits into from Jul 19, 2019
Merged

Add Banner component and add banner to all blog pages. #1178

merged 3 commits into from Jul 19, 2019

Conversation

robdodson
Copy link
Contributor

Fixes #1177

Changes proposed in this pull request:

  • Adds a new Banner paired shortcode
  • Adds a banner to all blog pages to ask folks to fill out our images survey.
  • Adds gnarly devsite hackery to make banner work while we wait for the next release build.

@googlebot googlebot added the cla: yes Contributor has signed the CLA label Jul 19, 2019
@netlify
Copy link

netlify bot commented Jul 19, 2019 •
edited

Deploy preview for web-dev-staging ready!

Built with commit 015dbd2

https://deploy-preview-1178--web-dev-staging.netlify.com

@robdodson
Copy link
Contributor Author

Banner is displayed on this page: https://deploy-preview-1178--web-dev-staging.netlify.com/blog

@robdodson robdodson mentioned this pull request Jul 19, 2019
Closed
mfriesenhahn
mfriesenhahn approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@mfriesenhahn mfriesenhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add the banner to the handbook components page when you have a sec?

@robdodson
Copy link
Contributor Author

oh yeah let me include that in this PR.

housseindjirdeh
housseindjirdeh approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 - it!!!

@robdodson robdodson merged commit 059c8ed into master Jul 19, 2019
@robdodson robdodson deleted the banner branch July 19, 2019 21:54
@robdodson robdodson mentioned this pull request Jul 24, 2019
Merged
@DUMIE505 DUMIE505 mentioned this pull request Feb 8, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@housseindjirdeh housseindjirdeh housseindjirdeh approved these changes

@mfriesenhahn mfriesenhahn mfriesenhahn approved these changes

Assignees
No one assigned
Labels
cla: yes Contributor has signed the CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a custom banner.
4 participants
@robdodson @housseindjirdeh @mfriesenhahn @googlebot