Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

feat(iframe): create iframe shortcode to enforce lazy loading of iframes, fixes #3154 #3620

Merged
merged 6 commits into from Aug 3, 2020

Conversation

MichaelSolati
Copy link
Contributor

No description provided.

@MichaelSolati MichaelSolati requested review from a team as code owners August 1, 2020 00:15
@googlebot googlebot added the cla: yes Contributor has signed the CLA label Aug 1, 2020
@netlify
Copy link

netlify bot commented Aug 1, 2020

Deploy preview for web-dev-staging ready!

Built with commit 4292319

https://deploy-preview-3620--web-dev-staging.netlify.app

@robdodson
Copy link
Contributor

robdodson commented Aug 3, 2020

This is looking good but I think we should also add a Glitch shortcode (maybe it can use the IFrame shortcode in its implementation?)

{% Glitch 'fav-kitties' %}

It'll need to support three arguments:

  • id (the id of the glitch to display)
  • path (this is the file the glitch will display first)
  • previewSize (this controls how much of the app preview is visible)

If path and previewSize aren't given then it should omit path from the query string, and set the previewSize to 100

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Contributor has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Waiting on document load event to load js delays table of contents.
3 participants