Minor fixes in about.html and other static pages under / #389
Conversation
tomayac
changed the title
lib/.devsite.js
Outdated
| C:/google/src/head/depot/google3/devrel/web/dev/devsite.js |
There was a problem hiding this comment.
I think this is going to break on all non-Windows systems. Could you revert this change?
There was a problem hiding this comment.
Huh, sorry, this seems like VS Code magic. Undone.
| @@ -53,7 +53,7 @@ <h2>Audit your web page</h2> | |||
| <h2>Analyze for improvements</h2> | |||
| </div> | |||
| <p> | |||
| Review the audits report to identify areas in which your page can be improved. Each day we'll generate a new report for you. | |||
| Review the audits report to identify areas in which your page can be improved. Each day we’ll generate a new report for you. | |||
There was a problem hiding this comment.
is the smart quote on purpose? just curious
There was a problem hiding this comment.
I was actually trying to figure out if this is a thing in the existing content, but wasn't able to check the code out on my laptop. In any case, I think we need to revert this for now.
There was a problem hiding this comment.
It uses smart quotes throughout the rest of the text, so I assumed it was missing.
Can’t rebase now, just about to board my plane to the US and on my phone only.
There was a problem hiding this comment.
I fixed them across the repo now. @robdodson PTAL
content/about.html
Outdated
| @@ -27,8 +27,8 @@ <h1 class="masthead-left__title"> | |||
| learned to any site they work on, be it personal or business. | |||
| </p> | |||
| <p> | |||
| web.dev was borne of a belief that if we make high quality | |||
| experiences easy to build it will enable more meaningful | |||
| web.dev was born of a belief that if we make high quality | |||
There was a problem hiding this comment.
apparently 'borne' is actually correct english. TIL
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
No description provided.