Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

docs(learncss): Add Transitions guide #6156

Merged
merged 27 commits into from Nov 2, 2021

Conversation

camden
Copy link
Contributor

@camden camden commented Sep 7, 2021

Fixes #5727

Changes proposed in this pull request:

  • add cambickel to web.dev contributors
  • add Transitions guide to LearnCSS
  • add Transitions page to LearnCSS Table of Contents

@netlify
Copy link

netlify bot commented Sep 7, 2021

✔️ Deploy Preview for web-dev-staging ready!

🔨 Explore the source changes: f83cba2

🔍 Inspect the deploy log: https://app.netlify.com/sites/web-dev-staging/deploys/618177b0cc7cfa0008dd4089

😎 Browse the preview: https://deploy-preview-6156--web-dev-staging.netlify.app

@chrome-devrel-review-bot
Copy link
Collaborator

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

src/site/content/en/learn/css/transitions/index.md

  • Please put a blank line before and after each section heading. Some Markdown parsers don't detect the text as a section heading unless there is blank space before and after it. Affected lines: 31, 34, 53, 64, 81, 100, 116, 125, 136, 148, 159, 170, 186, 211, 238

1 similar comment
@chrome-devrel-review-bot
Copy link
Collaborator

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

src/site/content/en/learn/css/transitions/index.md

  • Please put a blank line before and after each section heading. Some Markdown parsers don't detect the text as a section heading unless there is blank space before and after it. Affected lines: 31, 34, 53, 64, 81, 100, 116, 125, 136, 148, 159, 170, 186, 211, 238

@google-cla
Copy link

google-cla bot commented Sep 7, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no Contributor has not signed the CLA label Sep 7, 2021
@google-cla
Copy link

google-cla bot commented Sep 8, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Contributor has signed the CLA and removed cla: no Contributor has not signed the CLA labels Sep 8, 2021
@camden camden marked this pull request as ready for review September 8, 2021 00:40
@pullapprove pullapprove bot requested review from argyleink and una September 8, 2021 00:40
Copy link
Collaborator

@rachelandrew rachelandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly URLs, removing en-US from the MDN links so the reader gets their localization, and removing web.dev from internal links plus a few copy edits.

src/site/content/en/learn/css/transitions/index.md Outdated Show resolved Hide resolved
src/site/content/en/learn/css/transitions/index.md Outdated Show resolved Hide resolved
src/site/content/en/learn/css/transitions/index.md Outdated Show resolved Hide resolved
src/site/content/en/learn/css/transitions/index.md Outdated Show resolved Hide resolved
src/site/content/en/learn/css/transitions/index.md Outdated Show resolved Hide resolved
src/site/content/en/learn/css/transitions/index.md Outdated Show resolved Hide resolved
src/site/content/en/learn/css/transitions/index.md Outdated Show resolved Hide resolved
src/site/content/en/learn/css/transitions/index.md Outdated Show resolved Hide resolved
src/site/content/en/learn/css/transitions/index.md Outdated Show resolved Hide resolved
src/site/content/en/learn/css/transitions/index.md Outdated Show resolved Hide resolved
@rachelandrew rachelandrew added the DO NOT MERGE Actively working on but experimental label Sep 9, 2021
Copy link
Contributor

@argyleink argyleink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks rad! looks like you had fun!

@una
Copy link
Contributor

una commented Sep 16, 2021

Great module! I just added a few nits :) Thanks @camden

camden and others added 2 commits September 16, 2021 09:53
Co-authored-by: Una Kravets <una.kravets@gmail.com>
Fix broken link
@camden
Copy link
Contributor Author

camden commented Sep 16, 2021

Updated a handful of demos to improve color contrast (and color variety) and consistency, and just to make them look a little better.

@google-cla
Copy link

google-cla bot commented Oct 21, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no Contributor has not signed the CLA and removed cla: yes Contributor has signed the CLA labels Oct 21, 2021
@una una removed the DO NOT MERGE Actively working on but experimental label Nov 2, 2021
@google-cla
Copy link

google-cla bot commented Nov 2, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@camden
Copy link
Contributor Author

camden commented Nov 2, 2021

@googlebot I consent.

@una una added cla: yes Contributor has signed the CLA $-presubmit Add label to run presubmit tests. and removed cla: no Contributor has not signed the CLA labels Nov 2, 2021
@google-cla
Copy link

google-cla bot commented Nov 2, 2021

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no Contributor has not signed the CLA and removed cla: yes Contributor has signed the CLA labels Nov 2, 2021
@una una added cla: yes Contributor has signed the CLA and removed cla: no Contributor has not signed the CLA labels Nov 2, 2021
@google-cla
Copy link

google-cla bot commented Nov 2, 2021

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@una una merged commit 5057a73 into GoogleChrome:main Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
$-presubmit Add label to run presubmit tests. cla: yes Contributor has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LearnCSS] Module: Transitions
6 participants