This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
throw on missing i18n string #6170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for web-dev-staging ready! 🔨 Explore the source changes: 357dadd 🔍 Inspect the deploy log: https://app.netlify.com/sites/web-dev-staging/deploys/613945016272d7000772cac1 😎 Browse the preview: https://deploy-preview-6170--web-dev-staging.netlify.app |
MichaelSolati
approved these changes
Sep 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found strange (probably intended?) behavior in Nunjucks, that it was falling back to the previous
{{ title }}when the result of calling the i18n filter wasundefined.Anyway, the solution here is to actually barf on missing i18n strings. This was hitting us when a user tried to access a string like "i18n.courses.foo", when strings "i18n.courses.foo.bar" was actually defined (since the parent object existed, it just has no 'en' prop).