New design launch review

[devnook]

No description provided.

[netlify]

✔️ Deploy Preview for web-dev-staging ready!

🔨 Explore the source changes: 8193d12

🔍 Inspect the deploy log: https://app.netlify.com/sites/web-dev-staging/deploys/61815a03ceebfa0008da11e5

😎 Browse the preview: https://deploy-preview-6615--web-dev-staging.netlify.app

[chrome-devrel-review-bot]

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

src/site/content/en/index.md

• This file passed all of our automated Markdown audits.

src/site/content/en/patterns/layout/pancake-stack/index.md

• This file passed all of our automated Markdown audits.

src/site/content/es/index.md

• This file passed all of our automated Markdown audits.

src/site/content/ja/index.md

• This file passed all of our automated Markdown audits.

src/site/content/ko/index.md

• This file passed all of our automated Markdown audits.

src/site/content/pl/index.md

• This file passed all of our automated Markdown audits.

src/site/content/pt/index.md

• This file passed all of our automated Markdown audits.

src/site/content/ru/index.md

• This file passed all of our automated Markdown audits.

src/site/content/zh/index.md

• This file passed all of our automated Markdown audits.

[rachelandrew]

A few copy nits.

Also, the Learn PWA image is missing the word "PWA".

[rachelandrew]

I couldn't see it in this PR to change but under Patterns, the subhead "Layout Patterns" has Patterns capitalized, "Core Vitals patterns", lowercase. Style guide says headings should be sentence case so we should lowercase "Layout patterns".

[MichaelSolati]

Here's some thoughts/issues

On /measure, I had to test it on the live site cause I think the key is blocked from the netlify preview, but the results are displayed in dark mode even though my experience is set in light mode. Not a breaking issue, but a wonky design thing.

Learn design's logo in mobile, or with the compressed toc is very wonky. Not a breaking issue.

https://deploy-preview-6615--web-dev-staging.netlify.app/learn/design/

Nothing I think that should stop this from landing, just things to fix at some point.

[rachelandrew]

@devnook I'd like to do a copy edit of the layout patterns stuff so it meets the style guide. How am I best to do that, I could check out this branch, or am I better to do a new PR? Just wondering what is least likely to cause a git-mess.

[mihajlija]

• Learn PWA course is obviously WIP but it's displayed on the homepage
• The placeholder Example PatternSet is displayed on the homepage
• "Case Studies" in the top navigation bar should be "Case studies"
• Case study section still listing the oldest case studies

[mihajlija]

Not a blocker, but I think it would be better to display all available courses in a grid on the Learn page, rather than have the horizontal scroll. Especially weird since all the other items from Collections are expanded below.

https://deploy-preview-6615--web-dev-staging.netlify.app/learn/

[rachelandrew]

Not a blocker, but I think it would be better to display all available courses in a grid on the Learn page, rather than have the horizontal scroll. Especially weird since all the other items from Collections are expanded below.

I'm not a fan of the carousel either, when I first looked I was going to raise an issue asking where Learn CSS was, then realised it was in a carousel, that I hadn't realised was a carousel.

[devnook]

@rachelandrew let's do copy updates in separate Prs please

[rachelandrew]

I couldn't see it in this PR to change but under Patterns, the subhead "Layout Patterns" has Patterns capitalized, "Core Vitals patterns", lowercase. Style guide says headings should be sentence case so we should lowercase "Layout patterns".

I've dealt with this in a separate PR.

[rachelandrew]

Patterns: #6636

[devnook]

@mihajlija @rachelandrew Re: carousel - it is a part of the approved design for this launch. We are not going to change the design at this point, but we can definitely come back to this topic after cds.