Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Add initial responsiveness metric draft #6626

Merged
merged 11 commits into from
Nov 2, 2021
Merged

Add initial responsiveness metric draft #6626

merged 11 commits into from
Nov 2, 2021

Conversation

philipwalton
Copy link
Member

Fixes #6625

@philipwalton philipwalton added the $-presubmit Add label to run presubmit tests. label Nov 2, 2021
@chrome-devrel-review-bot
Copy link
Collaborator

chrome-devrel-review-bot commented Nov 2, 2021 •
edited
Loading

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

src/site/content/en/blog/responsiveness/index.md

  • Please change your usage of the following words:
    • Avoid please. Affected lines: 303

@google-cla google-cla bot added the cla: yes Contributor has signed the CLA label Nov 2, 2021
@netlify
Copy link

netlify bot commented Nov 2, 2021 •
edited
Loading

✔️ Deploy Preview for web-dev-staging ready!

🔨 Explore the source changes: b5cbd84

🔍 Inspect the deploy log: https://app.netlify.com/sites/web-dev-staging/deploys/6181bedea2e8540007fa54da

😎 Browse the preview: https://deploy-preview-6626--web-dev-staging.netlify.app

@github-actions github-actions bot removed the $-presubmit Add label to run presubmit tests. label Nov 2, 2021
@malchata
Makes minor changes.
30d0257 
- Changes a link's linked text.
- Updates the diagram with a cleaner version.
malchata
malchata approved these changes Nov 2, 2021
View reviewed changes
Copy link
Member

@malchata malchata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits and suggestions, plus an update to the diagram. None of these changed are strictly required before launching, so this LGTM.

philipwalton and others added 3 commits November 2, 2021 08:51
@philipwalton @mihajlija
Update src/site/content/en/blog/responsiveness/index.md
4770868 
Co-authored-by: Milica <mihajlija@google.com>
@philipwalton @mihajlija
Update src/site/content/en/blog/responsiveness/index.md
228c481 
Co-authored-by: Milica <mihajlija@google.com>
@philipwalton @mihajlija
Update src/site/content/en/blog/responsiveness/index.md
322cd5b 
Co-authored-by: Milica <mihajlija@google.com>
philipwalton and others added 3 commits November 2, 2021 08:58
@philipwalton @mihajlija
Update src/site/content/en/blog/responsiveness/index.md
6943652 
Co-authored-by: Milica <mihajlija@google.com>
@philipwalton @mihajlija
Update src/site/content/en/blog/responsiveness/index.md
9d20352 
Co-authored-by: Milica <mihajlija@google.com>
@philipwalton
Add code comments
10e0f6a
@philipwalton
Copy link
Member Author

OK, I've made all the updates. This can be merged any time.

@philipwalton philipwalton merged commit bf64f61 into main Nov 2, 2021
@philipwalton philipwalton deleted the responsiveness branch November 2, 2021 22:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rachelandrew rachelandrew rachelandrew left review comments

@mihajlija mihajlija mihajlija approved these changes

@npm1 npm1 npm1 left review comments

@hbsong235 hbsong235 hbsong235 left review comments

@malchata malchata malchata approved these changes

Assignees
No one assigned
Labels
cla: yes Contributor has signed the CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Vitals] Feedback wanted: an experimental responsiveness metric [11/3/2021]
7 participants
@philipwalton @chrome-devrel-review-bot @malchata @rachelandrew @mihajlija @npm1 @hbsong235