Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Adds CWV case study for The Economic Times. #6920

Merged
merged 7 commits into from
Dec 21, 2021
Merged

Adds CWV case study for The Economic Times. #6920

merged 7 commits into from
Dec 21, 2021

Conversation

malchata
Copy link
Member

Fixes #6093

Changes proposed in this pull request:

  • Adds CWV case study for The Economic Times.

cc: @mihajlija

@malchata malchata added content Issues related to content $-presubmit Add label to run presubmit tests. labels Nov 30, 2021
@google-cla google-cla bot added the cla: yes Contributor has signed the CLA label Nov 30, 2021
@netlify
Copy link

netlify bot commented Nov 30, 2021 •
edited
Loading

✔️ Deploy Preview for web-dev-staging ready!

🔨 Explore the source changes: 80b8158

🔍 Inspect the deploy log: https://app.netlify.com/sites/web-dev-staging/deploys/61c20289a077df0008eb4d2e

😎 Browse the preview: https://deploy-preview-6920--web-dev-staging.netlify.app

@chrome-devrel-review-bot
Copy link
Collaborator

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

src/site/content/en/blog/economic-times-cwv/index.md

  • This file passed all of our automated Markdown audits.

1 similar comment
@chrome-devrel-review-bot
Copy link
Collaborator

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

src/site/content/en/blog/economic-times-cwv/index.md

  • This file passed all of our automated Markdown audits.

jpmedley
jpmedley previously requested changes Dec 2, 2021
View reviewed changes
src/site/content/en/blog/economic-times-cwv/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/economic-times-cwv/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/economic-times-cwv/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/economic-times-cwv/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/economic-times-cwv/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/economic-times-cwv/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/economic-times-cwv/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/economic-times-cwv/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/economic-times-cwv/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/economic-times-cwv/index.md Outdated Show resolved Hide resolved
alexandrascript
alexandrascript suggested changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@alexandrascript alexandrascript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits -- mostly related to capitalization, a11y alt text and small copy suggestions.

src/site/content/en/blog/economic-times-cwv/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/economic-times-cwv/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/economic-times-cwv/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/economic-times-cwv/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/economic-times-cwv/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/economic-times-cwv/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/economic-times-cwv/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/economic-times-cwv/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/economic-times-cwv/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/economic-times-cwv/index.md Outdated Show resolved Hide resolved
@malchata @alexandrascript
Apply suggestions from code review
80b8158 
Co-authored-by: Alexandra White <alexandra.n.white@gmail.com>
@google-cla google-cla bot added cla: no Contributor has not signed the CLA and removed cla: yes Contributor has signed the CLA labels Dec 21, 2021
@google-cla google-cla bot added cla: yes Contributor has signed the CLA and removed cla: no Contributor has not signed the CLA labels Dec 21, 2021
@malchata malchata removed the request for review from jpmedley December 21, 2021 18:39
@malchata malchata dismissed jpmedley’s stale review December 21, 2021 18:43

This feedback was addressed.

@malchata malchata merged commit dec296c into GoogleChrome:main Dec 21, 2021
@malchata malchata deleted the economic-times-case-study branch December 21, 2021 18:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexandrascript alexandrascript alexandrascript approved these changes

@jpmedley jpmedley jpmedley left review comments

Assignees
No one assigned
Labels
$-presubmit Add label to run presubmit tests. cla: yes Contributor has signed the CLA content Issues related to content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Vitals][Runtime][CSS][DevTools] Economic Times cleared CWV across the origin
4 participants
@malchata @chrome-devrel-review-bot @alexandrascript @jpmedley