-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add adapter.js to Bower #104
Comments
Are you talking about running locally on a branch that's not synced with the master? Or do you mean the static content on the gh-pages branches? |
No, I'm talking about adapter.js is being used by a lot of third-party projects (for instance, at my job), so the only two solutions are to use a local copy updated by hand, or use RawGit. By registering it on Bower it can be updated and managed automatically. |
Do you want to create a PR showing how to do this? |
Hi @juberti, I've already registered the repo on Bower (it doesn't require any permissions and can be done by anybody since Bower registry works mostly as a URL shortener) and done a pull-request with the required bower.json metadata file so it's easily indexable and only download the adapter.js file and no others. |
Great idea – thanks. Will duly tweet/post. If no objections will close this issue. |
You are welcome @samdutton :-) Yes, this issue could be closed, it keeps remaining to accept the pull-request (or comment what needs to be fixed so it can be merged). |
Any update on this? Is there any issue with the pull-request? |
Thanks for your suggestion and pull request – apologies for delay in dealing with this. LGTM. We could add a Grunt task to check bower.json validity if necessary. Any objections to merging, @juberti or @KaptenJansson? |
I haven't taken the time to fully grok this but if it LGTY Sam go ahead. |
Don't worry, I supposed you were busy :-)
The content of the bower.json file will mostly don't change, since it "Si quieres viajar alrededor del mundo y ser invitado a hablar en un |
The idea of adding a bower.json check is simply to make sure that No big deal – just (maybe) a nice to have. On Thu, Nov 6, 2014 at 9:16 AM, Jesús Leganés Combarro <
|
i don't understand how should the grunt script work, if you explain me I would give it a try. |
Which grunt script – the one for adding new code demos? On Mon, Nov 10, 2014 at 11:31 AM, Jesús Leganés Combarro <
|
No, the one as a sanity check for the availability of the adapter.js file.
|
Ah – I meant this one: npmjs.org/package/grunt-bower-verify On Mon, Nov 10, 2014 at 11:45 AM, Jesús Leganés Combarro <
|
Didn't know of this package. Seems more focused to check that the "Si quieres viajar alrededor del mundo y ser invitado a hablar en un |
Yes. I don't think we definitely have to validate the Bower dependencies – I've merged your pull request. Thanks again for doing this – excellent suggestion. Sam On Mon, Nov 10, 2014 at 12:43 PM, Jesús Leganés Combarro <
|
Thank you for accepting it, I think it will be useful :-) One last note: I've check to download it on my machine and now it doesn't download the full repo (good! :-D ), but there are some pending useless files, maybe added after I did the pull-request: [piranna@Latitude:/tmp/prueba]
> tree
.
└── bower_components
└── adapter.js
├── bower.json
├── Gruntfile.js
├── LICENSE
├── package.json
├── README.md
└── samples
└── web
└── js
└── adapter.js
5 directories, 6 files Gruntfile.js and package.json shouldn't be there. I can be able to do a pull-request to add them to the ignore field, but it's not absolutely necesary :-) |
Ah... good spot. Obviously Gruntfile.js, etc., aren't required for (Gruntfile.js and package.json are used for build testing.) On Mon, Nov 10, 2014 at 2:29 PM, Jesús Leganés Combarro <
|
Here you have the updated bower.json file with Gruntfile.js and package.json on the ignore hash :-) |
This is done right? |
Yes, this is already done, I'll close the issue. Thanks to everybody :-) |
adapter.js is being currently used in a lot of pages, but this require to use a (probably outdated) local copy, or use some tricks like RawGit. A better solution would be to publish it on Bower, that's as easy as add a bower.json file and register it's location, and it will be updated automatically.
The text was updated successfully, but these errors were encountered: