Skip to content

Commit

Permalink
Address review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
philipwalton committed Sep 18, 2018
1 parent 88cfc94 commit 307cc7f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/workbox-core/_private/cacheWrapper.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import '../_version.mjs';
* @param {Request} options.request
* @param {Response} options.response
* @param {Event} [options.event]
* @param {Array} [options.plugins=[]]
* @param {Array<Object>} [options.plugins=[]]
*
* @private
* @memberof module:workbox-core
Expand Down
3 changes: 1 addition & 2 deletions packages/workbox-core/_private/fetchWrapper.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,8 @@ import '../_version.mjs';
*/
const wrappedFetch = async ({
request,
event,
fetchOptions,
preloadResponse,
event,
plugins = []}) => {
// We *should* be able to call `await event.preloadResponse` even if it's
// undefined, but for some reason, doing so leads to errors in our Node unit
Expand Down

0 comments on commit 307cc7f

Please sign in to comment.