Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the order of Route evaluation in v3 #845

Closed
jeffposnick opened this issue Oct 4, 2017 · 2 comments · May be fixed by Jeremip11/workbox#11
Closed

Change the order of Route evaluation in v3 #845

jeffposnick opened this issue Oct 4, 2017 · 2 comments · May be fixed by Jeremip11/workbox#11
Assignees
Labels
Breaking Change Denotes a "major" semver change.

Comments

@jeffposnick
Copy link
Contributor

Library Affected:
workbox-routing

In v1/v2 we gave precedence to the most-recently-registered Route when choosing the matching Route in our Router.

This was a somewhat arbitrary choice (I can't remember the original decision) and has periodically caused confusion, and in practice, has led to issues like #839

I'm cool with switching to making the earliest-registered Route take precedence in v3, which would match how things work in, e.g., Express.

@jeffposnick jeffposnick added the Breaking Change Denotes a "major" semver change. label Oct 4, 2017
@jeffposnick jeffposnick self-assigned this Oct 4, 2017
@gauntface
Copy link

+1. No question in my mind.

Is there anywhere we should track breaking changes like this? We could just do a markdown doc on webfundamentals workbox-v3 branch. We can all commit, it's public and will most likely be a good place to host the changelog. Thoughts?

@jeffposnick
Copy link
Contributor Author

This was done in #854.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Denotes a "major" semver change.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants