Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching to a db name instead of just a store name #1184

Merged
merged 4 commits into from Jan 18, 2018
Merged

Switching to a db name instead of just a store name #1184

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
176ced6
Switching to a db name instead of just a store name
Jan 17, 2018
65e0246
Adding versioning and fixing up the coverage to 100% for the module
Jan 18, 2018
fc9e8a2
Fixing linting errors
Jan 18, 2018
2e32fd6
Fixing linting errors
Jan 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/workbox-cache-expiration/models/CacheTimestampsModel.mjs
View file
Open in desktop
Expand Up @@ -38,7 +38,7 @@ class CacheTimestampsModel {
this._cacheName = cacheName;
this._storeName = cacheName;

this._db = new DBWrapper('workbox-cache-expiration', 1, {
this._db = new DBWrapper(this._cacheName, 1, {
onupgradeneeded: (evt) => evt.target.result
.createObjectStore(this._storeName, {keyPath: URL_KEY})
.createIndex(TIMESTAMP_KEY, TIMESTAMP_KEY, {unique: false}),
Expand Down
2 changes: 1 addition & 1 deletion test/workbox-cache-expiration/node/test-CacheTimestampsModel.mjs
View file
Open in desktop
Expand Up @@ -28,7 +28,7 @@ describe(`[workbox-cache-expiration] CacheTimestampsModel`, function() {
await model.setTimestamp('/', timestamp);

const timestamps =
await new DBWrapper(`workbox-cache-expiration`, 1).getAll('test-cache');
await new DBWrapper('test-cache', 1).getAll('test-cache');

expect(timestamps).to.deep.equal([{
url: 'https://example.com/',
Expand Down