Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari groups #1310

Merged
merged 2 commits into from Feb 14, 2018
Merged

Safari groups #1310

merged 2 commits into from Feb 14, 2018

Conversation

gauntface
Copy link

R: @jeffposnick @addyosmani

Fixes #1296

On Safari, don't log the Workbox prefix in logs as it silences the rest of the arguments. I checked the code and we only ever use a single string in group titles, so it's only the prefix that is the issue.

@workbox-pr-bot
Copy link
Collaborator

PR-Bot Size Plugin

Changed File Sizes

File Before After Change GZipped
packages/workbox-core/build/workbox-core.prod.js 6.40 KB 6.48 KB +1% 2.59 KB

New Files

No new files have been added.

All File Sizes

View Table
File Before After Change GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 3.27 KB 3.27 KB 0% 1.39 KB
packages/workbox-broadcast-cache-update/build/workbox-broadcast-cache-update.prod.js 1.07 KB 1.07 KB 0% 573 B
packages/workbox-build/build/_types.js 41 B 41 B 0% 61 B
packages/workbox-build/build/index.js 2.52 KB 2.52 KB 0% 1.06 KB
packages/workbox-cache-expiration/build/workbox-cache-expiration.prod.js 3.41 KB 3.41 KB 0% 1.26 KB
packages/workbox-cacheable-response/build/workbox-cacheable-response.prod.js 594 B 594 B 0% 350 B
packages/workbox-cli/build/app.js 5.09 KB 5.09 KB 0% 1.86 KB
packages/workbox-cli/build/bin.js 2.32 KB 2.32 KB 0% 1.03 KB
packages/workbox-core/build/workbox-core.prod.js 6.40 KB 6.48 KB +1% 2.59 KB
packages/workbox-google-analytics/build/workbox-google-analytics.prod.js 2.07 KB 2.07 KB 0% 1.02 KB
packages/workbox-precaching/build/workbox-precaching.prod.js 5.24 KB 5.24 KB 0% 2.04 KB
packages/workbox-range-requests/build/workbox-range-requests.prod.js 1.64 KB 1.64 KB 0% 807 B
packages/workbox-routing/build/workbox-routing.prod.js 2.77 KB 2.77 KB 0% 1.25 KB
packages/workbox-strategies/build/workbox-strategies.prod.js 3.26 KB 3.26 KB 0% 1.02 KB
packages/workbox-sw/build/workbox-sw.js 1.46 KB 1.46 KB 0% 793 B
packages/workbox-webpack-plugin/build/generate-sw.js 6.41 KB 6.41 KB 0% 2.17 KB
packages/workbox-webpack-plugin/build/index.js 742 B 742 B 0% 470 B
packages/workbox-webpack-plugin/build/inject-manifest.js 8.82 KB 8.82 KB 0% 2.89 KB

Workbox Aggregate Size Plugin

☠️ WARNING ☠️

We are using 155% of our max size budget.

Total Size: 22.68KB
Percentage of Size Used: 155%

Gzipped: 9.1KB

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 89.184% when pulling 9a55224 on safari-groups into aa95c44 on v3.

Copy link
Contributor

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User agent sniffing: 👃

(I know it's necessary!)

@gauntface gauntface merged commit d63d712 into v3 Feb 14, 2018
@gauntface gauntface deleted the safari-groups branch February 14, 2018 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants