Use an empty object rather than undefined when calling new Headers() #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipwalton
approved these changes
May 1, 2018
| @@ -29,7 +29,8 @@ import '../_version.mjs'; | |||
| * @memberof workbox.streams | |||
| */ | |||
| function createHeaders(headersInit) { | |||
| const headers = new Headers(headersInit); | |||
| // See https://github.com/GoogleChrome/workbox/issues/1461 | |||
| const headers = new Headers(headersInit || {}); | |||
There was a problem hiding this comment.
Optionally, headersInit could default to {} in the function declaration.
|
|
||
| import {createHeaders} from '../../../../packages/workbox-streams/utils/createHeaders.mjs'; | ||
|
|
||
| describe(`[workbox-streams] utils/createHeaders`, function() { | ||
| const sandbox = sinon.sandbox.create(); | ||
|
|
||
| afterEach(async function() { |
There was a problem hiding this comment.
Does this need to be async?
PR-Bot Size PluginChanged File SizesNo file sizes have changed. New Files
All File SizesView Table
Workbox Aggregate Size Plugin☠️ WARNING ☠️We are using 165% of our max size budget. Total Size: 24.14KB Gzipped: 9.38KB |
|
The review feedback's been addressed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @philipwalton
Fixes #1461
Small change needed to accommodate a quirk with the
Headersconstructor in Samsung Internet 6.4 (Chrome 56).