Standardize casing in API names #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffposnick
approved these changes
Jan 11, 2019
philipwalton
force-pushed
the
standardize-naming
branch
from
4bcc59e
to
bab6be5
Compare
|
No worries, I just copied over your changes and re-did the find and replace. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workbox has been somewhat inconsistent with respect to the casing in its API names. Specifically with regards to
SWvs.Sw, andURLvs.Url.This PR standardizes on
SWandURLper the W3C TAG's design principles doc, in an attempt to be as consistent as possible to the underlying web API names. It also updates any mixed-case event names to all lowercase.Here is a list of changes to the public API:
workbox-broadcast-cache-updatedata.payload.updatedURLworkbox-precachingworkbox.precaching.addRoute(options):options.cleanURLsworkbox.precaching.precacheAndRoute(entries, options):options.cleanURLsworkbox.precaching.PrecacheController:getCachedURLs()Note, I haven't changed any of the node tools yet (
workbox-build,workbox-cli, orworkbox-webpack-plugin) as we may try to accept both variants in v4, and log a deprecation warning.