Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve getSW correctly after an update is found #1941

Merged
merged 1 commit into from
Mar 6, 2019

Conversation

philipwalton
Copy link
Member

@philipwalton philipwalton commented Mar 6, 2019

R: @jeffposnick

Fixes #1939

The previous workbox-window logic would created a deferred for the instances "own" service worker and, once resolved, always return that service worker in the getSW() (and consequently the messageSW() method). But in the case of a SW already controlling the page and then an update being found for the same URL, this wouldn't be the desired behavior.

This PR updates the logic to handle this case.

/cc @Avocher

@workbox-pr-bot
Copy link
Collaborator

PR-Bot Size Plugin

Changed File Sizes

File Before After Change GZipped
packages/workbox-window/build/workbox-window.dev.umd.js 30.37 KB 30.52 KB +1% 8.07 KB
packages/workbox-window/build/workbox-window.prod.umd.js 4.65 KB 4.66 KB +0% 1.81 KB

New Files

No new files have been added.

All File Sizes

View Table
File Before After Change GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 3.21 KB 3.21 KB 0% 1.39 KB
packages/workbox-broadcast-update/build/workbox-broadcast-update.prod.js 1.86 KB 1.86 KB 0% 933 B
packages/workbox-build/build/_types.js 41 B 41 B 0% 61 B
packages/workbox-build/build/index.js 3.64 KB 3.64 KB 0% 1.36 KB
packages/workbox-cacheable-response/build/workbox-cacheable-response.prod.js 579 B 579 B 0% 344 B
packages/workbox-cli/build/app.js 5.58 KB 5.58 KB 0% 1.98 KB
packages/workbox-cli/build/bin.js 1.16 KB 1.16 KB 0% 580 B
packages/workbox-core/build/workbox-core.prod.js 5.34 KB 5.34 KB 0% 2.30 KB
packages/workbox-expiration/build/workbox-expiration.prod.js 2.83 KB 2.83 KB 0% 1.24 KB
packages/workbox-google-analytics/build/workbox-offline-ga.prod.js 1.89 KB 1.89 KB 0% 898 B
packages/workbox-navigation-preload/build/workbox-navigation-preload.prod.js 652 B 652 B 0% 317 B
packages/workbox-precaching/build/workbox-precaching.prod.js 4.25 KB 4.25 KB 0% 1.71 KB
packages/workbox-range-requests/build/workbox-range-requests.prod.js 1.51 KB 1.51 KB 0% 758 B
packages/workbox-routing/build/workbox-routing.prod.js 3.38 KB 3.38 KB 0% 1.47 KB
packages/workbox-strategies/build/workbox-strategies.prod.js 4.86 KB 4.86 KB 0% 1.19 KB
packages/workbox-streams/build/workbox-streams.prod.js 1.38 KB 1.38 KB 0% 677 B
packages/workbox-sw/build/workbox-sw.js 1.33 KB 1.33 KB 0% 741 B
packages/workbox-webpack-plugin/build/generate-sw.js 5.29 KB 5.29 KB 0% 1.84 KB
packages/workbox-webpack-plugin/build/index.js 349 B 349 B 0% 255 B
packages/workbox-webpack-plugin/build/inject-manifest.js 7.22 KB 7.22 KB 0% 2.48 KB
packages/workbox-window/build/workbox-window.dev.umd.js 30.37 KB 30.52 KB +1% 8.07 KB
packages/workbox-window/build/workbox-window.prod.umd.js 4.65 KB 4.66 KB +0% 1.81 KB

Workbox Aggregate Size Plugin

8.77KB gzip'ed (58% of limit)
22.04KB uncompressed

@philipwalton philipwalton merged commit 5e2c4a1 into master Mar 6, 2019
@philipwalton philipwalton deleted the workbox-window-update branch March 6, 2019 20:21
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 82.661% when pulling 46f1c2b on workbox-window-update into eab861f on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offer a page reload for users example broken
4 participants