Fix workbox-broadcast-update link #2212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, I think the fix for the problem here is our docs site needs to be updated. Specifically the file name of this file as well as some of its titles. @abraham if you're able to make that update and cc me, I can approve and merge. We also have a TODO to update some of the content there in line with v5 changes: #2122 |
|
Hmm, probably makes sense to also add a redirect in this file: https://github.com/google/WebFundamentals/blob/c3570fd9de43d40f91fcf9b3b22e7e64d227538b/src/content/en/tools/_redirects.yaml |
Merged
4 tasks
|
I've published the demos, and the page on developers.google.com/web/ should be updated too, so everything should work now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick @philipwalton
Current URL 404s.