Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set revision: null instead of deleting revision #2326

Merged
merged 2 commits into from Jan 13, 2020
Merged

Set revision: null instead of deleting revision #2326

merged 2 commits into from Jan 13, 2020

Conversation

jeffposnick
Copy link
Contributor

@jeffposnick jeffposnick commented Jan 13, 2020 •
edited

R: @philipwalton

This is needed to avoid a warning message due to a missing revision field, introduced in one of the earlier RCs.

See #2259 (comment)

@philipwalton
Copy link
Member

Looks like there are some legitimate test failures though.

@jeffposnick
Copy link
Contributor Author

While re-running following the latest commit, the failure is now #2321

I'm going to merge since the relevant tests work now.

@jeffposnick jeffposnick merged commit bb5f9a4 into master Jan 13, 2020
@jeffposnick jeffposnick deleted the revision-null branch January 13, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipwalton philipwalton philipwalton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeffposnick @philipwalton