Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per-method setDefaultHandler() #2463

Merged
merged 6 commits into from Jun 10, 2020
Merged

Per-method setDefaultHandler() #2463

merged 6 commits into from Jun 10, 2020

Conversation

jeffposnick
Copy link
Contributor

R: @philipwalton

Fixes #2434

The default method is GET and that's likely to be the most widely used method, but this is a breaking change since moving forward, a call to setDefaultHandler() won't cause POST, PUT, etc. requests to also match.

philipwalton
philipwalton approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@philipwalton philipwalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor naming nit.

packages/workbox-routing/src/Router.ts Outdated Show resolved Hide resolved
@jeffposnick jeffposnick merged commit f83fbc0 into v6 Jun 10, 2020
@jeffposnick jeffposnick deleted the set-default-handler branch June 10, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipwalton philipwalton philipwalton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Associate setDefaultHandler() calls with a HTTP method
2 participants
@jeffposnick @philipwalton