Update message to remove duplicate is
#2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffposnick
added a commit
that referenced
this pull request
Jul 8, 2020
* Update message to remove duplicate `is` (#2466) * v5.1.3 * gulp-glitch first pass (#2433) * removed old demos moved new demos on glitch into src folder * Removed gulp tasks * Linting * updated to 5.0.0 * clean commit of publish-glitch w/o problematic secrets in history * Added express server to top level Requires explanation w/in server * updated background sync strategies precaching w/ new updateServer.js * incrementing versions * updated precache express server * error handling in publish-glitch.js fixed error in workbox-core converted: workbox-cacheable-response workbox-expiration workbox-routing * tested pushing new version * updated: workbox-google-analytics workbox-range-requqests workbox-streams modified publish-glitch logging * updated final demos: workbox-broadcast-update workbox-navigation-preload workbox-window Co-authored-by: Jeff Posnick <jeffy@google.com> * resetting to upstream/master * pushing initial conversion attempt for workbox-cli * made changes per Jeff's comments * Removed some accidental files * Add a TS build step * WIP * Cleaned up tests * Linting * More linting * package.json test fix Co-authored-by: Adarsh Konchady <akonchady@gmail.com> Co-authored-by: Jeff Posnick <jeffy@google.com>
This was referenced Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting this message on a workbox build. Notice the duplicate 'is'.
R: @jeffposnick @philipwalton