Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when an async matchCallback is used #2591

Merged
merged 2 commits into from
Oct 7, 2020
Merged

Conversation

jeffposnick
Copy link
Contributor

R: @philipwalton

Some dev-only logging to help developers who are writing their own matchCallback functions, and mistakenly write them as async functions.

@jeffposnick
Copy link
Contributor Author

FWIW, this isn't something that TypeScript could catch. Right now we have:

export interface RouteMatchCallback {
  (options: RouteMatchCallbackOptions): any;
}

Ideally that any would be "any, excluding Promise", but that's not possible until microsoft/TypeScript#29317 is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants