Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing spaces in multiline logs #2627

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

piotr-cz
Copy link
Contributor

R: @jeffposnick @philipwalton

Add missing spaces in multiline logs

Should I post PR against v6 or master branch?
The gulp lint command shows lots of unrelated issues, and gulp test breaks with meassage Error: Cannot find module '@hapi/joi'

@jeffposnick jeffposnick self-requested a review September 10, 2020 14:40
Copy link
Contributor

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Yes, PR this should target the v6 branch.

The CI run is happy, so I think you might have just run into dependency trouble when switching between the v5 and v6 codebase?

@jeffposnick jeffposnick merged commit f993ab4 into GoogleChrome:v6 Sep 10, 2020
@piotr-cz
Copy link
Contributor Author

It's because simple npm install doesn't install subpackages dependencies like '@hapi/joi'

@piotr-cz piotr-cz deleted the fix-missing-spaces branch September 10, 2020 15:06
@jeffposnick
Copy link
Contributor

Ah. The dependencies of the various packages/* should all end up installed by lerna as a side-effect of running gulp build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants