Add setCatchHandler option for routes #2699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the Mac suite failed post-run in the cache phase? Re-running to hopefully get that to not fail. |
jeffposnick
suggested changes
Dec 14, 2020
jeffposnick
suggested changes
Dec 15, 2020
Co-authored-by: Jeffrey Posnick <jeffy@google.com>
This was referenced Mar 13, 2021
This was referenced Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2318
Added
setCatchHandlertoRoutebase class. Will try the route's catch handler first, if it exists, and falls back to default one if it doesn't, or if the route's catch handler has an error.