Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set preventAssignment in @rollup/plugin-replace #2772

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

jeffposnick
Copy link
Contributor

R: @tropicadri @philipwalton

Fixes #2769

The latest minor release of @rollup/plugin-replace has started logging messages about the new preventAssignment option, apparently in advance of some breaking changes in the next major release.

Folks using Workbox who end up with @rollup/plugin-replace v.2.4.0+ installed will get this message.

This PR explicitly updates our workbox-build and repo-level dependencies to require @rollup/plugin-replace v2.4.1, and explicitly sets preventAssignment: true, which should stop the logged warning messages.

(Based on how we're using @rollup/plugin-replace, preventAssignment: true should not result in any noticeable change.)

@jeffposnick jeffposnick merged commit 5a2d509 into v6 Mar 10, 2021
@jeffposnick jeffposnick deleted the replace-preventAssignment branch March 10, 2021 16:24
This was referenced Mar 15, 2021
This was referenced Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@rollup/plugin-replace 'preventAssignment' warning
2 participants