-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set preventAssignment in @rollup/plugin-replace #2772
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tropicadri
approved these changes
Mar 10, 2021
This was referenced Mar 15, 2021
Closed
This was referenced Mar 16, 2021
Closed
Bump workbox-build from 3.3.1 to 6.1.2 in /themes/docsy/assets/vendor/bootstrap
davidspek/website#34
Closed
This was referenced Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @tropicadri @philipwalton
Fixes #2769
The latest minor release of
@rollup/plugin-replace
has started logging messages about the newpreventAssignment
option, apparently in advance of some breaking changes in the next major release.Folks using Workbox who end up with
@rollup/plugin-replace
v.2.4.0+ installed will get this message.This PR explicitly updates our
workbox-build
and repo-level dependencies to require@rollup/plugin-replace
v2.4.1, and explicitly setspreventAssignment: true
, which should stop the logged warning messages.(Based on how we're using
@rollup/plugin-replace
,preventAssignment: true
should not result in any noticeable change.)