Migrate workbox-build to TypeScript #2867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tropicadri
requested changes
Jun 16, 2021
packages/workbox-build/src/lib/additional-manifest-entries-transform.ts
Outdated
Show resolved
Hide resolved
packages/workbox-build/src/lib/additional-manifest-entries-transform.ts
Outdated
Show resolved
Hide resolved
|
Thanks! Regarding the linting errors, I'm not going to be able to resolve the three instances of The other errors should be resolved now, though. |
Co-authored-by: Adriana Jara <32825533+tropicadri@users.noreply.github.com>
Co-authored-by: Adriana Jara <32825533+tropicadri@users.noreply.github.com>
…nsform.ts Co-authored-by: Adriana Jara <32825533+tropicadri@users.noreply.github.com>
…nsform.ts Co-authored-by: Adriana Jara <32825533+tropicadri@users.noreply.github.com>
Co-authored-by: Adriana Jara <32825533+tropicadri@users.noreply.github.com>
Co-authored-by: Adriana Jara <32825533+tropicadri@users.noreply.github.com>
Co-authored-by: Adriana Jara <32825533+tropicadri@users.noreply.github.com>
Co-authored-by: Adriana Jara <32825533+tropicadri@users.noreply.github.com>
tropicadri
approved these changes
Jun 16, 2021
packages/workbox-build/src/lib/additional-manifest-entries-transform.ts
Outdated
Show resolved
Hide resolved
…nsform.ts Co-authored-by: Adriana Jara <32825533+tropicadri@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @tropicadri
Fixes #2806, fixes #2477
There's obviously a lot going on in this PR. Sorry!
At a high level, this migrates
workbox-buildto TypeScript. (Following this PR, onlyworkbox-webpack-pluginandworkbox-sware written in JavaScript.)The goal was to preserve functionality during this migration, and not require a major semver bump. The biggest change under the hood is swapping out
@hapi/joioption validation for a two-part system that generates JSON schema based on our TypeScript definitions at build time, and then uses https://ajv.js.org/ to validate at runtime against that schema.@hapi/joiis a bit more sophisticated in terms of complex runtime validation (e.g. ensuring that if one option is set, another option needs to also be set, making options mutually exclusive, etc.) so some of those relationships needed to be expressed at runtime via custom functions, meaning that the generated JSON schema are not 100% the source of truth.Many of the test changes across all the packages reflect the fact that validation now throws slightly different errors due to the above mentioned change.
There are other small changes sprinkled throughout this PR as well, based on things that I found necessary while working with the additional TypeScript code. Please flag anything that looks amiss!