Fix request vs. response in ExpirationPlugin docs #2987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'If the request has a "Date" header' was particularly confusing and led me down the wrong path
|
Thanks for catching—and fixing—this! |
jeffposnick
approved these changes
Nov 30, 2021
This was referenced Dec 2, 2021
Merged
This was referenced Mar 1, 2022
Open
Open
1 task
This was referenced Apr 5, 2022
This was referenced Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the request has a "Date" headerwas particularly confusing and led me down the wrong pathPrior to creating a pull request, please follow all the steps in the contributing guide.
R: @jeffposnick @tropicadri