Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ineffective config #24

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Ineffective config #24

merged 2 commits into from
Sep 1, 2020

Conversation

henrym2
Copy link
Collaborator

@henrym2 henrym2 commented Aug 28, 2020 •
edited
Loading

Fixes #23

  • Tests pass
  • Appropriate changes to README are included in PR
  • 90% test coverage

@henrym2
Added context checker
0126852 
Added tests
added context service
@henrym2
Fixed linting
f61a95c
@henrym2 henrym2 requested a review from rowan-m August 28, 2020 11:56
@henrym2 henrym2 self-assigned this Aug 28, 2020
rowan-m
rowan-m approved these changes Sep 1, 2020
View reviewed changes
Copy link
Collaborator

@rowan-m rowan-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@henrym2 henrym2 merged commit 3c321a1 into main Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowan-m rowan-m rowan-m approved these changes

Assignees

@henrym2 henrym2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emit some kind of developer warning when running with an ineffective config
2 participants
@henrym2 @rowan-m