Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ux/improved hover and select #57

Merged
merged 24 commits into from
Aug 30, 2018
Merged

Conversation

argyleink
Copy link
Collaborator

@argyleink argyleink commented Aug 28, 2018

i'm actually not convinced this is better. needs more work, but want to post it for anyone to peep. love to hear thoughts.

known issues:

  • labels and other items supposed to be "attached" to the node, dont track changes anymore. needs observer to notify subscribers
  • multiselect only highlights one
  • not all tools should/need some of these features, still trying to find a proper mixture of ui feedback

things to try:

  • inspector
  • guides tool
  • any other tool (get the new hover feedback like devtools)

@argyleink argyleink added 🔥 enhancement New feature or request ¿ question ? Further information is requested 🔎 needs tested pending validation from target users labels Aug 28, 2018
@argyleink
Copy link
Collaborator Author

feeling much better in the newer iteration

@argyleink argyleink added this to In progress in v1 Aug 30, 2018
@argyleink
Copy link
Collaborator Author

this is ready for QA, I think it's ready to merge, feels very nice, and is clean in the DOM

@argyleink argyleink merged commit 291b9df into master Aug 30, 2018
@argyleink argyleink moved this from In progress to Done in v1 Aug 30, 2018
@argyleink argyleink deleted the ux/improved-hover-and-select branch September 6, 2018 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 enhancement New feature or request 🔎 needs tested pending validation from target users ¿ question ? Further information is requested
Projects
v1
  
Done 👍
Development

Successfully merging this pull request may close these issues.

None yet

1 participant